Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable cluster local TLS tests for Contour #15378

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Enable cluster local TLS tests for Contour #15378

merged 2 commits into from
Jul 12, 2024

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jul 8, 2024

Fixes #14375

Proposed Changes

Release Note

Contour now supports TLS encryption of cluster local routes

@knative-prow knative-prow bot requested review from izabelacg and skonto July 8, 2024 15:59
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 8, 2024
@dprotaso
Copy link
Member Author

dprotaso commented Jul 8, 2024

/hold for changes in net-contour

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.58%. Comparing base (a923915) to head (151b64d).
Report is 11 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15378      +/-   ##
==========================================
- Coverage   84.62%   84.58%   -0.05%     
==========================================
  Files         219      219              
  Lines       13584    13587       +3     
==========================================
- Hits        11496    11493       -3     
- Misses       1723     1726       +3     
- Partials      365      368       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2024
@dprotaso
Copy link
Member Author

dprotaso commented Jul 8, 2024

Screenshot 2024-07-08 at 1 35 35 PM

woot going to revert the manual build

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2024
skonto
skonto reviewed Jul 11, 2024
View reviewed changes
test/e2e/clusterlocaldomaintls/cluster_local_domain_tls_test.go
t.Skip("Skip this test for non-kourier ingress.")
if !strings.Contains(test.ServingFlags.IngressClass, "kourier") ||
strings.Contains(test.ServingFlags.IngressClass, "contour") {
t.Skip("Skip this test for non-kourier/contour ingress.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused, should not we remove skipping for contour?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check is inverted, so only run for kourier and now contour.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually the second clause isn't inverted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I missed that. Maybe use brackets around it then to make it more obvious?

ReToCode
ReToCode approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2024
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 11, 2024
@dprotaso
Copy link
Member Author

/test contour-latest_serving_main

@dprotaso
Copy link
Member Author

/contour-tls_serving_main

@dprotaso
Copy link
Member Author

/test contour-tls_serving_main

@dprotaso
Copy link
Member Author

HA test failed - re-running since this merged in #15359

@dprotaso
Copy link
Member Author

Ok it merged

/test contour-latest_serving_main

@dprotaso
Copy link
Member Author

Screenshot 2024-07-11 at 3 28 30 PM

Passed - verified the cluster local & system internal tests ran and passed

ReToCode
ReToCode approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member Author

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2024
@knative-prow knative-prow bot merged commit 44a5d78 into knative:main Jul 12, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skonto skonto skonto left review comments

@ReToCode ReToCode ReToCode approved these changes

@izabelacg izabelacg Awaiting requested review from izabelacg

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cluster-local-domain-tls] host cluster-local certificates with SNI in net-contour
3 participants
@dprotaso @skonto @ReToCode